Both this branch and main independently applied the same GROUP BY optimization to closure status queries, causing conflicts. Merged main and resolved conflicts, plus addressed reviewer feedback on the benchmark files.

Description

Conflict resolution (backend/closure_service.py, backend/routers/grievances.py):

• Both branches made identical GROUP BY optimization with different formatting; accepted main's more compact version

backend/tests/test_closure_status_benchmark.py:

• Removed unused sys, os imports
• Extracted module-level engine/create_all into _make_session() to prevent DB side effects at pytest collection time
• Added a real test_grouped_query_faster_than_separate() pytest function verifying correct counts from the GROUP BY query

backend/tests/benchmark_closure_status.py:

• Removed unused imports: sys, os, get_db, ClosureService, patch, MagicMock, and sys.path.insert
• Fixed seed_data() to populate all required non-null Grievance fields (severity, current_jurisdiction_id, assigned_authority, sla_deadline) — previously would raise IntegrityError on commit

Type of Change

• 🐛 Bug fix (non-breaking change which fixes an issue)
• ✨ New feature (non-breaking change which adds functionality)
• 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
• 📝 Documentation update
• 🎨 Code style update (formatting, renaming)
• ♻️ Refactoring (no functional changes)
• ⚡ Performance improvement
• ✅ Test update

Related Issue

Closes #

Testing Done

• Tested locally
• Added/updated tests
• All tests passing

Screenshots (if applicable)

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• Any dependent changes have been merged and published

Co-Authors

📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

Summary by cubic

Optimizes closure status counts with a single GROUP BY query and replaces detection caching with a faster, thread‑safe cache. Adds facial emotion detection and an in‑app camera capture to improve reporting. Aligns with Linear 6106104410388610831.

• Refactors

  • Use one COUNT(*) GROUP BY query for closure confirmations in closure_service and grievances router; preserves API shape (missing statuses → 0).
  • Replace manual detection cache with ThreadSafeCache (TTL+LRU, O(K) expiry cleanup) to reduce latency.

• New Features

  • New /api/detect-emotion endpoint using Hugging Face dima806/facial_emotions_image_detection and detectorsApi.emotion client method.
  • ReportForm integrates react-webcam to snap photos; converts captures to File for existing upload flow.
  • Remove duplicate frontend/public/_redirects to fix Netlify deploy.

^{Written for commit 23a5e8e. Summary will update on new commits.}